Skip to content

Add more docs for CoerceUnsized and Unsize #38816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2017
Merged

Add more docs for CoerceUnsized and Unsize #38816

merged 1 commit into from
Jan 10, 2017

Conversation

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Jan 4, 2017 •
edited
Loading

here be dragons

r? @ubsan @steveklabnik

strega-nil
strega-nil reviewed Jan 4, 2017
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good on the technical aspects, otherwise.

src/libcore/marker.rs Outdated
Copy link
Contributor

@strega-nil strega-nil Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be T is Unsize<Trait> when T: Trait, in order to be consistent with the above sentence.

src/libcore/ops.rs Outdated
Copy link
Contributor

@strega-nil strega-nil Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For builtin types" sounds unclear; perhaps reword this to say something to the effect of "for builtin pointer types".

src/libcore/ops.rs Outdated
Copy link
Contributor

@strega-nil strega-nil Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit; where U: ?Sized is, afaik, not valid syntax. Another argument for supporting it?

Copy link
Member Author

@Manishearth Manishearth Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The docs also output this form. There is no reason not to support it IMO.

@Manishearth
Copy link
Member Author

Manishearth commented Jan 4, 2017

Updated.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jan 4, 2017

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 4, 2017

📌 Commit 07e844f has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 4, 2017
@GuillaumeGomez
Rollup merge of rust-lang#38816 - Manishearth:coercion-doc, r=Guillau…
05913bd 
…meGomez

Add more docs for CoerceUnsized and Unsize

here be dragons

r? @ubsan @steveklabnik
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 4, 2017
Closed
@steveklabnik steveklabnik mentioned this pull request Jan 4, 2017
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 4, 2017
@steveklabnik
Rollup merge of rust-lang#38816 - Manishearth:coercion-doc, r=Guillau…
6316e43 
…meGomez

Add more docs for CoerceUnsized and Unsize

here be dragons

r? @ubsan @steveklabnik
@nrc
Copy link
Member

nrc commented Jan 5, 2017

cc @rust-lang/lang to make sure the docs fit our beliefs

@frewsxcv frewsxcv mentioned this pull request Jan 9, 2017
Closed
@nikomatsakis nikomatsakis self-assigned this Jan 9, 2017
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Jan 10, 2017
@sanxiyn
Rollup merge of rust-lang#38816 - Manishearth:coercion-doc, r=Guillau…
ac27238 
…meGomez

Add more docs for CoerceUnsized and Unsize

here be dragons

r? @ubsan @steveklabnik
@sanxiyn sanxiyn mentioned this pull request Jan 10, 2017
Merged
bors added a commit that referenced this pull request Jan 10, 2017
@bors
Auto merge of #38958 - sanxiyn:rollup, r=sanxiyn
7bffede 
Rollup of 11 pull requests

- Successful merges: #38606, #38607, #38623, #38664, #38799, #38816, #38836, #38839, #38841, #38849, #38874
- Failed merges: #38845
@bors bors merged commit 07e844f into rust-lang:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@strega-nil strega-nil strega-nil left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakis nikomatsakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Manishearth @GuillaumeGomez @bors @nrc @strega-nil @nikomatsakis